Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Instructions for expedited restoration of WaitForFirstConsumer volumes #975

Merged
merged 1 commit into from
Nov 12, 2024
Merged

Instructions for expedited restoration of WaitForFirstConsumer volumes #975

merged 1 commit into from
Nov 12, 2024

Conversation

Zash
Copy link
Contributor

@Zash Zash commented Oct 15, 2024

⚠️ IMPORTANT ⚠️: This is a public repository. Make sure to not disclose:

  • personal data beyond what is necessary for interacting with this Pull Request;
  • business confidential information, such as customer names.

Quality gates:

  • I'm aware of the Contributor Guide and did my best to follow the guidelines.
  • I'm aware of the Glossary and did my best to use those terms.

Adds disaster recovery instructions for restoring volumes that don't yet have a
Pod, because Velero waits until a Pod mounts the volume before restoring
data.

@Zash Zash force-pushed the ka/unattached-volumes branch 2 times, most recently from 708e3ab to ede07f3 Compare October 23, 2024 11:22
@Zash Zash changed the title WaitForFirstConsumer Instructions for expedited restoration of WaitForFirstConsumer volumes Oct 23, 2024
@Zash Zash force-pushed the ka/unattached-volumes branch 2 times, most recently from 8aef225 to b4f90c0 Compare October 25, 2024 10:42
@Zash Zash force-pushed the ka/unattached-volumes branch 3 times, most recently from 64c68d7 to ecbc2bd Compare November 1, 2024 10:46
@Zash Zash marked this pull request as ready for review November 1, 2024 10:58
@Zash Zash requested a review from a team as a code owner November 1, 2024 10:58
Elias-elastisys
Elias-elastisys approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@Elias-elastisys Elias-elastisys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work, lgtm!

robinAwallace
robinAwallace approved these changes Nov 5, 2024
View reviewed changes
Copy link
Contributor

@robinAwallace robinAwallace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👍 It looks good to me, just a question. Is this still the case when using snapshoting?

@Zash Zash merged commit 372a0bf into main Nov 12, 2024
1 check passed
@Zash Zash deleted the ka/unattached-volumes branch November 12, 2024 12:06
@Zash
Copy link
Contributor Author

Zash commented Nov 12, 2024

Nice 👍 It looks good to me, just a question. Is this still the case when using snapshoting?

This is what you do when using volumesnapshots as I understand.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elias-elastisys Elias-elastisys Elias-elastisys approved these changes

@robinAwallace robinAwallace robinAwallace approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Zash @robinAwallace @Elias-elastisys